Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove IP Address based node replace procedure #2027

Merged
merged 1 commit into from
Jul 23, 2024
Merged

Remove IP Address based node replace procedure #2027

merged 1 commit into from
Jul 23, 2024

Conversation

zimnx
Copy link
Collaborator

@zimnx zimnx commented Jul 17, 2024

Description of your changes:

Procedure which was executed for ScyllaDB versions <5.2 and <2023.1 is removed, as these versions are no longer supported. Nodes are going to be replaced only using HostID based procedure.

Which issue is resolved by this Pull Request:
Resolves #2026

@zimnx zimnx added kind/feature Categorizes issue or PR as related to a new feature. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. labels Jul 17, 2024
@scylla-operator-bot scylla-operator-bot bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jul 17, 2024
@scylla-operator-bot scylla-operator-bot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 17, 2024
@zimnx zimnx force-pushed the remove-ip-replace branch 2 times, most recently from 8fd1519 to f2397d1 Compare July 17, 2024 21:13
tnozicka
tnozicka reviewed Jul 18, 2024
View reviewed changes
Copy link
Member

@tnozicka tnozicka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
in general, please update the docs as well

@zimnx
Remove IP Address based node replace procedure
efaff12 
Procedure which was executed for ScyllaDB versions <5.2 and <2023.1 is removed, as these versions are no longer supported.
Nodes are going to be replaced only using HostID based procedure.
@zimnx
Copy link
Collaborator Author

zimnx commented Jul 18, 2024

please update the docs as well

what you would like to update?

Minimal Scylla versions mentioned in docs for v1.13 are already high enough to cover this change. Replace procedure described in docs doesn't mention IP addresses. And ReplaceFirstAddressBoot in Status is already deprecated.

@tnozicka
Copy link
Member

ok, with that it looks like we are good there, thx

@zimnx
Copy link
Collaborator Author

zimnx commented Jul 22, 2024

@tnozicka @rzetelskik please take a look

tnozicka
tnozicka reviewed Jul 22, 2024
View reviewed changes
Copy link
Member

@tnozicka tnozicka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm
/assign @rzetelskik

rzetelskik
rzetelskik approved these changes Jul 22, 2024
View reviewed changes
Copy link
Member

@rzetelskik rzetelskik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@scylla-operator-bot scylla-operator-bot bot added the lgtm Indicates that a PR is ready to be merged. label Jul 22, 2024
@scylla-operator-bot scylla-operator-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rzetelskik, tnozicka, zimnx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@zimnx
Copy link
Collaborator Author

zimnx commented Jul 22, 2024

Flake - #1028 (comment)

/retest

@zimnx
Copy link
Collaborator Author

zimnx commented Jul 23, 2024

Flake - #1028 (comment)
/retest

@scylla-operator-bot scylla-operator-bot bot merged commit 446cd5c into scylladb:master Jul 23, 2024
12 checks passed
@zimnx zimnx deleted the remove-ip-replace branch July 23, 2024 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tnozicka tnozicka tnozicka left review comments

@rzetelskik rzetelskik rzetelskik approved these changes

Assignees

@rzetelskik rzetelskik

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove IP address based replace procedure
3 participants
@zimnx @tnozicka @rzetelskik